<html>
<head><meta charset="utf-8"><title>Refactor the partitioning module PR #74275 · t-compiler/wg-incr-comp · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/index.html">t-compiler/wg-incr-comp</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Refactor.20the.20partitioning.20module.20PR.20.2374275.html">Refactor the partitioning module PR #74275</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="207358716"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Refactor%20the%20partitioning%20module%20PR%20%2374275/near/207358716" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Refactor.20the.20partitioning.20module.20PR.20.2374275.html#207358716">(Aug 19 2020 at 00:29)</a>:</h4>
<p>Hey <span class="user-mention" data-user-id="125250">@Wesley Wiser</span> regarding PR <a href="https://github.com/rust-lang/rust/issues/74275">#74275</a></p>



<a name="207358722"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Refactor%20the%20partitioning%20module%20PR%20%2374275/near/207358722" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Refactor.20the.20partitioning.20module.20PR.20.2374275.html#207358722">(Aug 19 2020 at 00:29)</a>:</h4>
<p>the first big commit, the commit text says that its the one that adds thet rait</p>



<a name="207358785"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Refactor%20the%20partitioning%20module%20PR%20%2374275/near/207358785" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Refactor.20the.20partitioning.20module.20PR.20.2374275.html#207358785">(Aug 19 2020 at 00:30)</a>:</h4>
<p>but its basically impossible to  use the diff to validate changes that are associated with the addition of the trait</p>



<a name="207358828"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Refactor%20the%20partitioning%20module%20PR%20%2374275/near/207358828" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Refactor.20the.20partitioning.20module.20PR.20.2374275.html#207358828">(Aug 19 2020 at 00:30)</a>:</h4>
<p>Can you restructure. the commits, adding an extra. one at the beginning that <em>just</em> does the shuffling of code into new files/mods?</p>



<a name="207358833"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Refactor%20the%20partitioning%20module%20PR%20%2374275/near/207358833" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Refactor.20the.20partitioning.20module.20PR.20.2374275.html#207358833">(Aug 19 2020 at 00:31)</a>:</h4>
<p>Yeah, that's fair. I can split adding the trait and moving the code around into separate commits.</p>



<a name="207358845"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Refactor%20the%20partitioning%20module%20PR%20%2374275/near/207358845" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Refactor.20the.20partitioning.20module.20PR.20.2374275.html#207358845">(Aug 19 2020 at 00:31)</a>:</h4>
<p>thanks. It would make the review easier.</p>



<a name="207358866"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Refactor%20the%20partitioning%20module%20PR%20%2374275/near/207358866" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Refactor.20the.20partitioning.20module.20PR.20.2374275.html#207358866">(Aug 19 2020 at 00:31)</a>:</h4>
<p>That's true. I should have done it that way to begin with.</p>



<a name="207358940"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Refactor%20the%20partitioning%20module%20PR%20%2374275/near/207358940" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Refactor.20the.20partitioning.20module.20PR.20.2374275.html#207358940">(Aug 19 2020 at 00:32)</a>:</h4>
<p>I'm going to bed in about an hour so I probably won't have this ready for review tonight. I'll ping you again when it's ready for review.</p>



<a name="207358941"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Refactor%20the%20partitioning%20module%20PR%20%2374275/near/207358941" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Refactor.20the.20partitioning.20module.20PR.20.2374275.html#207358941">(Aug 19 2020 at 00:32)</a>:</h4>
<p>let me know if you want advise on git incantations. to ease this revision</p>



<a name="207358962"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Refactor%20the%20partitioning%20module%20PR%20%2374275/near/207358962" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Refactor.20the.20partitioning.20module.20PR.20.2374275.html#207358962">(Aug 19 2020 at 00:33)</a>:</h4>
<p>Okay no problem.  Sorry again for the. many week delay; i could have given you this. feedback a long time ago</p>



<a name="207359000"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Refactor%20the%20partitioning%20module%20PR%20%2374275/near/207359000" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Refactor.20the.20partitioning.20module.20PR.20.2374275.html#207359000">(Aug 19 2020 at 00:33)</a>:</h4>
<p>No problem! It hasn't been been very bit-rot-y :)</p>



<a name="207965343"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Refactor%20the%20partitioning%20module%20PR%20%2374275/near/207965343" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Refactor.20the.20partitioning.20module.20PR.20.2374275.html#207965343">(Aug 25 2020 at 13:54)</a>:</h4>
<p>FYI, this is ready for review. Thanks for the feedback!</p>



<a name="207993793"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Refactor%20the%20partitioning%20module%20PR%20%2374275/near/207993793" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Refactor.20the.20partitioning.20module.20PR.20.2374275.html#207993793">(Aug 25 2020 at 17:28)</a>:</h4>
<p>thanks!</p>



<a name="207993803"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Refactor%20the%20partitioning%20module%20PR%20%2374275/near/207993803" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Refactor.20the.20partitioning.20module.20PR.20.2374275.html#207993803">(Aug 25 2020 at 17:28)</a>:</h4>
<p>looking now</p>



<a name="207998189"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Refactor%20the%20partitioning%20module%20PR%20%2374275/near/207998189" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Refactor.20the.20partitioning.20module.20PR.20.2374275.html#207998189">(Aug 25 2020 at 17:59)</a>:</h4>
<p>okay r+'ed. Thanks <span class="user-mention" data-user-id="125250">@Wesley Wiser</span> !</p>



<a name="207999731"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/Refactor%20the%20partitioning%20module%20PR%20%2374275/near/207999731" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/Refactor.20the.20partitioning.20module.20PR.20.2374275.html#207999731">(Aug 25 2020 at 18:10)</a>:</h4>
<p>Thanks <span class="user-mention" data-user-id="116083">@pnkfelix</span>!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>